code-review-practiceslisted

# Code Review Practices This skill provides guidance for conducting effective, constructive code reviews that improve code quality and team collaboration. ## Review Mindset **Goals of code review:** - Catch bugs and issues early - Share knowledge across the team - Maintain code quality standards - Improve code maintainability - Foster learning and growth **Not goals:** - Assert dominance or superiority - Enforce personal preferences - Block progress unnecessarily - Nitpick without value ## What to Review ### 1. Correctness **Does the code work as intended?** - Logic is sound - Edge cases are handled - Error conditions are managed - Requirements are met ### 2. Design and Architecture **Does it fit the system?** - Follows existing patterns - Appropriate abstractions - Reasonable complexity - Scalable approach ### 3. Readability **Can others understand it?** - Clear naming - Logical organization - Appropriate comments - Consistent style ### 4. Testing **Is it adequately tested?** - Tests exist for new code - Edge cases covered - Tests are maintainable - Integration points tested ### 5. Security **Are there security concerns?** - Input validation - Authentication/authorization - Sensitive data handling - Known vulnerabilities ### 6. Performance **Will it perform well?** - No obvious bottlenecks - Efficient algorithms - Resource usage reasonable - Scalability considered ## Review Process ### 1. Understand Context Before reviewing code: - Read PR description and