code-reviewlisted

# Code Review **Approval standard:** Approve when the change definitely improves overall code health, even if it isn't perfect. Don't block because it isn't how you would have written it. **Core principle:** Review early, review often. ## The Five-Axis Review ### 1. Correctness - Does it match the spec or task requirements? - Are edge cases handled (null, empty, boundary values)? - Are error paths handled (not just happy path)? - Do tests cover the change adequately? ### 2. Readability - Are names descriptive and consistent with project conventions? - Is control flow straightforward? - Could this be done in fewer lines without sacrificing clarity? - Are abstractions earning their complexity? - Any dead code artifacts (unused variables, commented-out blocks)? ### 3. Architecture - Does it follow existing patterns or introduce a justified new one? - Does it maintain clean module boundaries? - Is the abstraction level appropriate? ### 4. Security - Is user input validated and sanitized? - Are secrets kept out of code, logs, and version control? - Is auth checked where needed? - Are SQL queries parameterized? - Is external data treated as untrusted? ### 5. Performance - Any N+1 query patterns? - Any unbounded loops or unconstrained data fetching? - Any missing pagination on list endpoints? ## Severity Labels | Prefix | Meaning | Author Action | |--------|---------|---------------| | *(none)* | Required change | Must address before merge | | **Critical:** | Blocks merge