gstack-reviewlisted

# gstack-review — Pre-Landing PR Review ## When to invoke Use when asked to "review this PR", "code review", "pre-landing review", "check my diff", or when proactively suggesting review before merge. Analyze the diff against the base branch for SQL safety, trust boundary violations, conditional side effects, and other structural issues. ## Workflow ### Step 1: Get the diff ```bash git diff origin/main...HEAD # or the target base branch ``` If the user specifies a different base branch, use that instead. ### Step 2: Two-pass review **Pass 1 (CRITICAL):** SQL & Data Safety, Race Conditions & Concurrency, LLM Output Trust Boundary, Shell Injection, Enum & Value Completeness. **Pass 2 (INFORMATIONAL):** Async/Sync mixing, column/field name safety, dead code, LLM prompt issues, completeness gaps, time window safety, type coercion at boundaries, view/frontend, CI/CD pipeline. ### Step 3: Output format ``` Pre-Landing Review: N issues (X critical, Y informational) **AUTO-FIXED:** - [file:line] Problem → fix applied **NEEDS INPUT:** - [file:line] Problem description Recommended fix: suggested fix ``` If no issues found: `Pre-Landing Review: No issues found.` ## Review Categories ### Pass 1 — CRITICAL #### SQL & Data Safety - String interpolation in SQL - TOCTOU races: check-then-set patterns that should be atomic - Bypassing model validations for direct DB writes - N+1 queries: missing eager loading for associations used in loops/views #### Race Conditions & Con