← ClaudeAtlas

pattern-reviewer-non-functionallisted

Reviewer lens for the non-functional dimension of a production-code review (performance, reliability, scalability, resource use). Grades each gap under a strict spec-gated rule: HIGH (blocks) ONLY when it maps to a declared non-functional AC on a touched surface; floor gaps with no NFR AC (unbounded read, N+1, missing timeout) are Defer/Nit, never HIGH — so a slice with no NFR ACs is never blocked, only advised. Security is out of scope. Activate on a backend/frontend production-code review.
MartinKChen/harness-claude-code · ★ 0 · AI & Automation · score 72
Install: claude install-skill MartinKChen/harness-claude-code
# pattern-reviewer-non-functional The reviewer's lens for the non-functional pillar of the code gate — performance efficiency, reliability, scalability, and resource utilization (ISO 25010 / ISTQB non-functional quality characteristics). The substance — *what bound should exist* — lives in **`pattern-engineer-non-functional`** and is shared verbatim with the engineer who writes the code. This skill governs only the reviewer's verb: **detect a gap against that catalogue, grade it under the spec-gated rule, cite it, and report it** so the fix flow can act on it. > **Load `pattern-engineer-non-functional` first.** Walk its *thin floor* and its *spec-gated targets* against the scoped diff to find gaps; everything below is how you turn each gap into a posted finding — and, above all, how you grade it so this lens never blocks a slice that didn't ask for the work. ## When to activate - The dispatched caller is reviewing the **production-code gate** on a slice whose diff touches `type:backend` or `type:frontend` surfaces. Run on every such dispatch. - A user says "review performance", "are there N+1s / unbounded queries", "will this scale", "did we meet the latency / capacity requirement". - Do NOT activate on the security gate (`pattern-reviewer-security`) or the pre-implementation `test-coverage` gate (there is no production code to audit yet). Test files are out of scope. ## Project memory overlay After loading this skill, also check `$MAIN_ROOT/.claude/memory/patterns/patt