code-review-checklistlisted

# Code Review Checklist ## 1. Task Compliance - [ ] **Requirements:** Fulfills all "Changes Description" items? - [ ] **Acceptance Criteria:** Met? - [ ] **Use Cases:** Main scenario works? ## 2. Implementation Quality - [ ] **Top-Down/Stubs:** - *Stub Task:* Returns hardcoded values? NO logic? E2E checks hardcode? - *Impl Task:* Real logic replaces stub? E2E updated? - [ ] **No Duplication:** used existing methods/helpers? - [ ] **Error Handling:** Exceptions caught and logged? - [ ] **Code Smells:** No magic numbers, understandable names? - [ ] **Dead Code:** Before proposing a deletion — symbol grepped repo-wide? (callout below) > ### Before acting on a "remove dead code" finding > 1. **Grep the symbol repo-wide — never scope the search to a test directory.** Tests are not > always in one: Go keeps `*_test.go` beside the source, Rust puts unit tests inline under > `#[cfg(test)]`, JS/TS co-locates `*.spec.ts` / `__tests__/`, Python uses `tests/`, Foundry > uses `test/*.t.sol`. A directory-scoped grep returns "nothing depends on it" precisely where > that answer is wrong. > 2. **If a test drives it, the fix is not deletion** — make production reach the branch (wire the > flag, pass the parameter) so code and requirement agree. > 3. **Report it as "unreachable *and* covered by test X"**, not "dead, delete". A finding can be > right about the smell and wrong about the fix. ## 3. Documentation "First" - [ ] **Directory Docs:** `.AGENTS.md` updated