← ClaudeAtlas

review-logiclisted

Use when: reviewing code for logic correctness, algorithmic bugs, missing error handling, async/await mistakes, null/undefined risks, race conditions, type contract violations, or spec compliance. Dispatched by review-orchestrator for --frontend, --backend, and --all. Also invoked directly: "review logic", "check correctness", "are there any bugs here". NOT for: security vulnerabilities, performance profiling, style/naming preferences, or architectural pattern concerns — those belong in their respective specialized reviewers.
MrCipherSmith/helyx · ★ 1 · AI & Automation · score 71
Install: claude install-skill MrCipherSmith/helyx
# Review Logic Specialized reviewer for **logic correctness and algorithmic soundness**. Inherits from the original `code-ai-review` + `code-boss-review` correctness phases and unifies them into a single focused pass. This reviewer does not care about formatting, naming, or architecture opinions. Every finding must describe an observable, reproducible defect or a spec gap. --- ## Workflow ``` Logic Review Progress: - [ ] Step 1: Read Job Context (if provided) - [ ] Step 2: Determine git scope (merge-base) - [ ] Step 3: Collect diff - [ ] Step 4: Stage 1 — Spec compliance check (if issue/task provided) - [ ] Step 5: Scan for logic bugs and type contract violations - [ ] Step 6: Scan for async/race conditions and error handling gaps - [ ] Step 7: Scan for null/undefined/optional chaining risks - [ ] Step 8: Scan for edge cases and incorrect algorithm assumptions - [ ] Step 9: Emit findings in unified format ``` --- ## Input Contract | Field | Type | Required | Description | |-------|------|----------|-------------| | `branch` | string | no | Branch to review. Defaults to current branch. | | `commit_range` | string | no | Explicit hash or range. Overrides merge-base detection. | | `issue_url` | string | no | GitHub issue or task URL. Required for Stage 1 spec compliance gate. | | `context_doc` | string | no | Path to job context document. | --- ## Scope Detection See shared script: `skills/shared/git-merge-base.md` Run the script to determine `BASE_SHA`, then collect