← ClaudeAtlas

design-checklisted

Design checklist distilled from repeated code-review findings. Use before writing code from a design or spec, before opening a PR, and when writing a design or architecture review. Covers dependency direction, where a shared guard lives, docs that must move with the code, every copy of a fixed cause, the paths a change did not edit, fakes that match the real service, failure and empty states, tests that claim only real guarantees, races with deletes, and which layer owns a limit.
SummerRiversound/awesome-claude-harness · ★ 0 · Web & Frontend · score 72
Install: claude install-skill SummerRiversound/awesome-claude-harness
# Design check Rules reviewers kept raising. Go through every one before the first line of code and again before the PR; fix what fails, or write down in the PR why it stays. - **Dependencies point one way.** A base module that must import a module built on top of it means the design is upside down. Once you start adding type-only import stubs, lazy imports or protocol shells to dodge a cycle, stop and turn the direction around. A mixin that needs members of its host is better as a module function that takes the host as an argument. - **A shared guard lives at one entry point.** Put the check once in the base class's public method (template method) instead of copying it into every subclass. If you need a meta-test that checks no copy was missed, the copying is the cost. - **Design docs move with the code, in the same PR.** When a decision changes, change its line in the ADR or spec in that PR. Every place that repeats a number, list or name (overview, tables, QA notes, API descriptions) shows the same value. - **Fix every copy of the cause.** Before calling a fix done, search the repo for the same pattern (the call, the literal, the copied branch) and fix each hit or list the ones left in the PR body. Write the ones left into the issue the PR closes as well, so a leftover is not filed again as a new bug. Reviewers find the sibling call site the fix skipped more often than a flaw in the fix itself. - **Find the paths you did not edit.** Before the first line of code, list th