factory-reviewlisted
Install: claude install-skill The-Zoop-Troop/software-factory-rs
# Factory review — read what landed like a colleague's PR
An epic closing means every task was **verified and landed**; it does not mean anyone read
the code. This skill is the closing step of every phase: the factory made the diff small
enough to review — so review it. Wanted changes go back **through the factory**, not as hand
edits.
Handles: `R="docker compose -p factory-<rig> --env-file ~/.factory/<rig>/compose.env -f compose.yaml"`;
remote access via `FACTORY_RIG`/`FACTORY_TOKEN`. Context: `docs/guides/first-project.md` §7.
## Workflow
1. **Fetch and frame the diff.** One squash commit per task, titled by task; `main` untouched.
```sh
git fetch origin
git log --oneline origin/main..origin/<feature-branch>
git diff --stat origin/main...origin/<feature-branch>
git log -1 origin/main # still the pre-run commit — if not, stop and investigate
```
2. **Verify beads first — the commands are the contract.** For each task, read what actually
ran (console task drawer, or `$R exec steward sh -c 'cd /work/rig && factory bead show <task-id>'`).
A verify command weaker than the plan intended is a **plan fix for the next phase**, not a
code edit now. Note any task that landed on a retry — read its failed attempt's verify
output to learn why.
3. **Tests were ADDED, not just passed.** Every task's acceptance said tests; confirm the
diff contains them:
```sh
git diff origin/main...origin/<feature-branch> --stat -- '*test*' '*spec*'