← ClaudeAtlas

review-agent-runtimelisted

Domain Q&A gate for the wrai.th relay runtime — the Go/MCP/SQLite core that is the shared coordination backbone for the whole agent fleet. Routes on a diff touching main.go, serve_lock_*.go, embed_hooks.go, or internal/ (db, relay, ingest, cli, config, models). A regression here does not fail one caller — it silently blinds every agent at once, so the checklist leads with data-integrity and concurrency, not style.
TsukumoHQ/WRAI.TH · ★ 33 · AI & Automation · score 83
Install: claude install-skill TsukumoHQ/WRAI.TH
# review-agent-runtime — the fleet-backbone gate This runtime is a **single-writer SQLite relay serving many concurrent agents over MCP**. The failure mode that matters is not a crash — a crash is loud. It is a change that *silently* drops a message, empties a result set, double-claims a task, or opens the API to the network. Review in that order: integrity first, availability second, boundary third, surface last. Only assert an item the diff actually touches. Mechanical checks (build with `-tags fts5`, `go vet`, `gofmt`, `golangci-lint`, the test suite) are the CI gate's job, not this document's. Every item below is a judgment call CI cannot make. ## 1. Schema & scan lockstep — the single most destructive silent bug - [ ] **`agentColumns` and `scanAgent` change together or not at all.** `agents.go` builds every agent SELECT from the `agentColumns` const (16 columns today) and unpacks it in `scanAgent`. Add a column to one string without the other and the scan arity mismatches — `Query` errors are often swallowed and the call returns **zero rows**, so a live fleet reads as empty. If the diff edits either, re-count both by hand; a passing build does not catch a column that scans into the wrong field. - [ ] **Wide-table additions go through `ensureColumns` + a dedicated query, never by widening `agentColumns`.** Widening the shared column list re-arities every existing query at once; an isolated column + its own reader can't drop unrelated result sets. - [ ] **Migrations are