review-testslisted
Install: claude install-skill YoniChechik/claude-code-config
# Review Tests Mode
Review all tests for quality issues and fix any problems found.
## Additional review focus
"$ARGUMENTS"
If provided, the above gives optional extra constraints or focus areas for the test review. By default, the skill reviews all tests for quality issues without needing any arguments.
## Process
Use a subagent to carry out the following:
### Test Review
Review ALL written tests for quality issues:
- **Mock abuse**: tests that mock so much they're testing mock behavior, not real code
- **Shallow coverage**: tests that only check happy paths
- **Missing edge cases**: empty inputs, None values, boundary conditions, error scenarios
- **Tautological tests**: tests that assert the mock returns what you told it to return
- **Test isolation**: each test must be independent, no shared mutable state
- **Meaningful assertions**: no `assert True`, no asserting only that no exception was thrown
- **Test names**: should describe the behavior being tested, not the implementation
- **Deleted tests**: if any test functions/methods were deleted — a deleted test is ONLY acceptable if the code it tested was also deleted. If a test was removed because it was failing, it must be fixed, not deleted. Flag suspicious test deletions.
- **Silent test failures**: tests must fail loudly — no test should be silently skipped or produce false passes because of missing dependencies, fixtures, data, or configuration. Flag patterns like `pytest.importorskip()` without justification,