antipattern-cataloglisted

# Anti-Pattern Catalog Documents technical debt and patterns to avoid. ## Process 1. **Collect observations** — Gather issues from Phase 1 & 2 analyses 2. **Categorize** — Structural, behavioral, observability, performance 3. **Assess severity** — Critical, major, minor, cosmetic 4. **Generate remediation** — Suggest fixes for each pattern 5. **Create checklist** — "Do Not Repeat" guidelines ## Anti-Pattern Categories ### Structural Anti-Patterns Issues with code organization, inheritance, and modularity. | Pattern | Symptom | Example | |---------|---------|---------| | **Deep Inheritance** | 5+ levels of class hierarchy | `Agent → BaseAgent → RunnableAgent → ExecutableAgent → ...` | | **God Class** | One class with 50+ methods | `AgentExecutor` doing routing, execution, memory, tools | | **Circular Dependencies** | Module A imports B, B imports A | `agent.py ↔ tools.py` | | **Leaky Abstraction** | Implementation details exposed | Base class assumes specific LLM response format | | **Premature Abstraction** | Over-engineered for flexibility | 5 interfaces for a single implementation | ### Behavioral Anti-Patterns Issues with runtime behavior and logic. | Pattern | Symptom | Example | |---------|---------|---------| | **Hidden State Mutation** | State changes not obvious | `tool.run()` modifies agent's memory | | **Implicit Contracts** | Undocumented assumptions | Tools assume specific message format | | **Silent Failures** | Errors swallowed | `except: pass` in tool