code-review-standardslisted

# Code Review Standards ## When to Use - Reviewing pull requests - Performing code reviews - Defining review criteria - Establishing review process ## Overview Code review standards ensure consistent, thorough reviews that catch bugs before they reach production. This skill aggregates criteria from specialized skills. ## Review Framework ### 4-Level Severity Classification 1. **CRITICAL** 🔴 - Must fix before merge - Security vulnerabilities - Data loss risks - Authentication bypasses - SQL injection risks 2. **HIGH** 🟠 - Should fix before merge - TypeScript strict mode violations - Missing error handling - Performance issues (N+1 queries) - Missing input validation 3. **MEDIUM** 🟡 - Fix soon (can merge with plan) - Code quality issues - Missing tests - Poor naming - Missing documentation 4. **LOW** 🟢 - Nice to have - Style suggestions - Optimization opportunities - Refactoring ideas --- ## Review Checklist ### 1. Correctness → See: [correctness-criteria.md](./correctness-criteria.md) - [ ] Logic is correct for all test cases - [ ] Edge cases handled (null, empty, max, min) - [ ] Error conditions properly handled - [ ] Return types match function signatures - [ ] Async operations properly awaited - [ ] No race conditions - [ ] No off-by-one errors --- ### 2. Security → See: [security-sentinel skill](../security-sentinel/SKILL.md) → See: [security-checklist.md](./security-checklist.md) **CRITICAL - Must check ever