code-reviewlisted

# Code Review A systematic approach to reviewing diffs and pull requests. Work through the categories below in order — correctness first, style last. --- ## Pre-read checklist Before reading the diff: - Read the PR description. Does it explain *why* the change is needed? If the description is missing or just "fixes stuff", ask for one before reviewing — the diff alone won't tell you whether the approach is right. - Check the linked issue or ticket if there is one. - Note the rigor tier (`patterns/profiles/` or `.agentharness-profile`) — the coverage and testing requirements differ. --- ## 1. Correctness The most important category. Ask: *"Can this code produce wrong results?"* - Does the logic match the stated goal? - Are there off-by-one errors, wrong comparisons, or incorrect assumptions about the data? - Are all inputs validated before use? - Are edge cases handled: empty collections, zero, null/None/undefined, negative numbers, max values, concurrent access? - Does error handling actually handle the error, or does it swallow it silently? - Are exceptions caught at the right level (not too broad, not too narrow)? - Are resources (files, connections, locks) released even on exception? ```python # Swallowed error — caller sees success, wrong data silently used try: value = parse_config(raw) except Exception: pass # WRONG: value is now unset or stale # RIGHT: propagate or at minimum log + re-raise try: value = parse_config(raw) except ConfigEr