← ClaudeAtlas

definition-of-done-reviewlisted

Reviews a change against this team's Definition of Done before merge. It goes beyond generic code review by checking acceptance criteria, contract fidelity, proportional verification and test coverage, docs/ADR updates, and security for sensitive areas, then gives a pass/fail verdict with evidence appropriate to each item. Use at Stage 6 after code-review and simplify, or when the user asks "is this ready to merge" or "run the DoD check".
enocgit/sdlc-kit · ★ 1 · Code & Development · score 74
Install: claude install-skill enocgit/sdlc-kit
# definition-of-done-review Run this team-specific check after generic `code-review` and `simplify`. Those checks catch bugs and cleanup issues; this one verifies readiness against the team's standard. ## Review modes ### Local readiness before Land Check every locally verifiable DoD item before push or PR creation. Resolve `reviewTarget` as the exact tip of the human-designated landing branch: fetch its configured authoritative remote when one exists, or use the human-designated local tip whenever no authoritative remote exists, regardless of tracker mode. An unreachable configured remote blocks local readiness. Build a versioned SHA-256 identity for the prospective Git tree or the already-committed tree. Choose one evidence path: - **Prospective review:** record `reviewBase` as the exact pre-commit `HEAD`. Build the prospective tree through a temporary index: from the repository root, create a mode-`0700` temporary directory and use a nonexistent path inside it as `GIT_INDEX_FILE`; clean the directory with a trap. Initialize that index with `git read-tree "$reviewBase^{tree}"`, then run `git add -A` against it; never modify the real index. This makes Git apply the active attributes and clean filters exactly as it will during the commit. A missing or failed filter blocks readiness rather than falling back to raw working-tree bytes. - **Already-committed review:** require `git status --porcelain=v1 --untracked-files=all` to be empty. Set `reviewedCommit` to