review-checklistlisted

# Review Checklist Skill Reviewing in PostgreSQL is structured into **seven phases** per the wiki. Run them in order — the cheap checks first, the deep ones last. The same checklist applies pre-submission (review our own work) and post-submission (review someone else's CF entry). ## Companion skills This skill is the **orchestration layer**. When a phase points into a specialist domain, hand off to the corresponding skill instead of re-deriving the deep rules here: - `wal-and-xlog` — WAL records, redo functions, RM registration, hint bits - `locking` — lock primitive choice and acquisition order - `error-handling` — `ereport`/`elog`/SQLSTATE/message-style choices - `memory-contexts` — `palloc` placement, context lifetimes - `coding-style` — pgindent survival, include order, C99 subset - `catalog-conventions` — `pg_proc`/catalog column/OID assignment work - `testing` — picking regress vs isolation vs TAP vs module - `commit-message-style` — judging committer-readiness of the message - `patch-submission` — pre-submission of our own change ## Phase 0 — Reviewer-reflex gates + REJECT-track (added 2026-06-12) Three persona-driven gates + the REJECT-A/B/C grade rubric. Both fire before the mechanical checks. Each gate was triggered repeatedly across the five Phase C calibrations (`knowledge/calibration/`); leaving them implicit causes the mechanical-only review to ship patches that real reviewers will push back on. If any gate fails, the patch goes back to the author with the