code-reviewlisted
Install: claude install-skill seankoji-com/frugalbar
# Review priorities
frugalbar's entire value proposition is that every number it shows is real.
AGENTS.md documents the incidents below as things that actually shipped —
treat them as the review checklist, not hypotheticals.
## Spend real attention here
- **Synthesized quotas.** Any change in `Sources/QuotaBarCore/Providers/`
that fills a missing value instead of returning `.unavailable`/nil —
`?? 500`, a hardcoded pace marker, a plan name defaulted to the vendor's
name, a balance shown under a "spent" label nobody measured.
`consumptionFraction`, `expectedPaceFraction`, `planName`, and `spent`
must stay optional all the way through.
- **HTTP status before decode.** A response handler that parses JSON
without checking `http.statusCode` first — 404 must map to `.badResponse`,
429 must map to `.rateLimited`, never render as a full or critical bar.
- **New `ProviderStatus` / `UnavailableReason` cases** (`MetricTypes.swift`).
These compile fine and silently fall into an existing `Urgency`/
`Confidence` bucket if not mapped on purpose — check both axes are set
deliberately, and that a new `UnavailableReason` also updates `headline`,
`remedy`, and `SettingsView.verify`.
- **Credential handling.** Keys sent as query params instead of headers;
`error.localizedDescription` or any raw `URLError` landing in a
persisted or user-facing `QuotaSnapshot` field (it carries the request
URL).
- **Preferences reads/writes.** Anything touching `UserDefaults.standard