← ClaudeAtlas

solidlisted

SOLID design review rules (SRP, OCP, LSP, ISP, DIP) for code reviews: what counts as a real design finding, what is only taste, how to cite it and how severe it is. Use when reviewing a diff, a pull request or recent changes for design problems, when asked for a "SOLID review", "design review", "is this class doing too much", or when a review checklist asks for SOLID. Pair it with the dry skill for duplication and with owasp-asvs for security.
siva01c/claude-plugins · ★ 16 · Code & Development · score 78
Install: claude install-skill siva01c/claude-plugins
# SOLID Review A design finding is worth reporting only when the design **already costs something or will on the next ordinary change** — a bug, an inconsistency, a change that has to touch many places, a unit that cannot be tested. Style, naming taste, "could be more elegant" and textbook purity are never findings. ## Scope Review the changed code and what it calls, read whole — not only the diff hunks. Judge the change against the conventions the repository already follows (its `AGENTS.md`/`CLAUDE.md`, existing seams and patterns). A repo that keeps small scripts procedural is not violating SOLID by doing so. ## Rules ### SRP — Single Responsibility One unit (function, class, module, service) has to change for **two unrelated reasons**. Name both reasons in the finding. - Finding: an HTTP controller that validates input, builds SQL, renders e-mail and spawns a child process; a Drupal form submit handler that also syncs to a remote API. - Not a finding: a long function that does one thing in several steps. ### OCP — Open/Closed Adding the **next variant** (a check, a backend, a provider, a content type) requires editing a `switch`/`if` chain in **several** places instead of one registration point (a map, a plugin type, a tagged service, an event subscriber). - Cite every place the next variant would have to touch. - Not a finding: a single `match` in one place that is the registration point. ### LSP — Liskov Substitution An implementation that **throws, no-ops