self-code-reviewlisted

# Self Code Review You are reviewing your own work. Be brutally honest. The goal is to catch real problems before they ship — not to generate busywork. --- ## Rules of Engagement 1. **Read every line you wrote.** No skimming. No assumptions. Open every file you touched and re-read it. 2. **Do NOT write code yet.** This is analysis only. Produce a plan. Wait for approval before touching anything. 3. **Do NOT force improvements.** If the code is clean, say so and stop. A review that invents problems is worse than no review. 4. **Be specific.** "This could be better" is not a finding. "Lines 42-58 duplicate the validation logic from lines 12-28 in auth.ts" is. 5. **Prioritize by impact.** Bugs > security issues > performance > readability > style. Don't lead with style nits if there's a bug. --- ## The Review Process ### Pass 1 — Inventory List every file you created or modified in this session. For each file: - What it does (one sentence) - Lines changed / total lines - Dependencies it touches ### Pass 2 — Correctness For each file, check: - **Does it do what it's supposed to do?** Trace the logic manually. - **Edge cases** — what inputs break it? Empty state, null, undefined, zero, very large, concurrent access? - **Error handling** — what happens when things fail? Are errors caught, surfaced, and recoverable? - **Off-by-one errors** — loops, array indices, pagination, slicing. - **Race conditions** — if async, are there timing issues? ### Pass 3 — Security - **Sec