maintainer-pr-welcomelisted
Install: claude install-skill vivekbhange-hub/maintainer-skill
# Welcoming PR review
A first PR decides whether someone becomes a regular contributor. The review has to be right
(you are still the gate on quality) and it has to be the kind of review that makes them want
to open a second PR. This skill does both: a real code review, written in a teaching voice.
## Steps
1. **Load the PR.**
```
gh pr view <n> --json number,title,body,author,baseRefName,headRefName,files,additions,deletions,commits,labels,isDraft,closingIssuesReferences,url
gh pr diff <n>
gh pr checks <n>
```
Check whether this is their first contribution:
`gh pr list --state all --author <login> --limit 5 --json number,state`. One result means
first PR; mention that in the welcome line. If `gh pr checks` shows failures, read the failing
job log (`gh run view <run-id> --log-failed`) and explain the cause in plain words.
2. **Learn the house style** before judging style: CONTRIBUTING.md, PR template, lint/format
config (`.editorconfig`, `ruff.toml`, `.eslintrc*`, `rustfmt.toml`), and two or three nearby
files the PR touches. A convention only counts if the repo actually follows it.
3. **Review for correctness first.** Read every changed file in full context (Read the whole
function, not only the hunk). Check, in order:
- Does it do what the linked issue asks? Does it change behaviour the issue did not ask for?
- Edge cases: empty input, None/null, errors, concurrency, Windows paths, unicode.
- Tests: is there a test that fail