test-discipline

Solid

Update tests when changing APIs — no exceptions

AI & Automation 58 stars 15 forks Updated 2 weeks ago MIT

Install

View on GitHub

Quality Score: 84/100

Stars 20%
59
Recency 20%
90
Frontmatter 20%
70
Documentation 15%
85
Issue Health 10%
50
License 10%
100
Description 5%
100

Skill Content

## Context When APIs or public interfaces change, tests must be updated in the same commit. When test assertions reference file counts or expected arrays, they must be kept in sync with disk reality. Stale tests block CI for other contributors. ## Patterns - **API changes → test updates (same commit):** If you change a function signature, public interface, or exported API, update the corresponding tests before committing - **Test assertions → disk reality:** When test files contain expected counts (e.g., `EXPECTED_FEATURES`, `EXPECTED_SCENARIOS`), they must match the actual files on disk - **Add files → update assertions:** When adding docs pages, features, or any counted resource, update the test assertion array in the same commit - **CI failures → check assertions first:** Before debugging complex failures, verify test assertion arrays match filesystem state ## Examples ✓ **Correct:** - Changed auth API signature → updated auth.test.ts in same commit - Added `distributed-mesh.md` to features/ → added `'distributed-mesh'` to EXPECTED_FEATURES array - Deleted two scenario files → removed entries from EXPECTED_SCENARIOS ✗ **Incorrect:** - Changed spawn parameters → committed without updating casting.test.ts (CI breaks for next person) - Added `built-in-roles.md` → left EXPECTED_FEATURES at old count (PR blocked) - Test says "expected 7 files" but disk has 25 (assertion staleness) ## Anti-Patterns - Committing API changes without test updates ("I'll fix tests later") - ...

Details

Author
DanWahlin
Repository
DanWahlin/ai-agent-board
Created
6 months ago
Last Updated
2 weeks ago
Language
TypeScript
License
MIT

Integrates with

Similar Skills

Semantically similar based on skill content — not just same category