shell-review

## Table of Contents - [Quick Start](#quick-start) - [When to Use](#when-to-use) - [Required TodoWrite Items](#required-todowrite-items) - [Workflow](#workflow) - [Output Format](#output-format) # Shell Script Review Audit shell scripts for correctness, safety, and portability. ## Verification After review, run `shellcheck <script>` to verify fixes address identified issues. ## Testing Run `pytest plugins/pensive/tests/skills/test_shell_review.py -v` to validate review patterns. ## Quick Start ```bash /shell-review path/to/script.sh ``` ## When To Use - CI/CD pipeline scripts - Git hook scripts - Wrapper scripts (run-*.sh) - Build automation scripts - Pre-commit hook implementations ## When NOT To Use - Non-shell scripts (Python, JS, etc.) - One-liner commands that don't need review ## Required TodoWrite Items 1. `shell-review:context-mapped` 2. `shell-review:exit-codes-checked` 3. `shell-review:portability-checked` 4. `shell-review:safety-patterns-verified` 5. `shell-review:evidence-logged` ## Workflow ### Step 1: Map Context (`shell-review:context-mapped`) Identify shell scripts: ```bash # Find shell scripts find . -not -path "*/.venv/*" -not -path "*/__pycache__/*" \ -not -path "*/node_modules/*" -not -path "*/.git/*" \ -name "*.sh" -type f | head -20 # Check shebangs rg -l "^#!/" scripts/ hooks/ 2>/dev/null | head -10 # fallback: grep -l "^#!/" scripts/ hooks/ 2>/dev/null | head -10 ``` Document: - Script purpose and trigger context - Integration po...