architecture-review

# Architecture Review Skill Analyze project structure at the macro level - packages, modules, layers, and boundaries. ## When to Use - User asks "review the architecture" / "check project structure" - Evaluating package organization - Checking dependency direction between layers - Identifying architectural violations - Assessing clean/hexagonal architecture compliance --- ## Quick Reference: Architecture Smells | Smell | Symptom | Impact | |-------|---------|--------| | Package-by-layer bloat | `service/` with 50+ classes | Hard to find related code | | Domain → Infra dependency | Entity imports `@Repository` | Core logic tied to framework | | Circular dependencies | A → B → C → A | Untestable, fragile | | God package | `util/` or `common/` growing | Dump for misplaced code | | Leaky abstractions | Controller knows SQL | Layer boundaries violated | --- ## Package Organization Strategies ### Package-by-Layer (Traditional) ``` com.example.app/ ├── controller/ │ ├── UserController.java │ ├── OrderController.java │ └── ProductController.java ├── service/ │ ├── UserService.java │ ├── OrderService.java │ └── ProductService.java ├── repository/ │ ├── UserRepository.java │ ├── OrderRepository.java │ └── ProductRepository.java └── model/ ├── User.java ├── Order.java └── Product.java ``` **Pros**: Familiar, simple for small projects **Cons**: Scatters related code, doesn't scale, hard to extract modules ### Package-by-Feature (Recommended) ``` ...