go-quality-review

# Go Quality Review ## Purpose Audit Go code for structural quality, style conformance, and modern Go practices. This skill is the **designated lint-tool runner** — other vertical review skills do NOT run golangci-lint/staticcheck/go vet, avoiding duplicate execution. This skill does NOT cover: security, concurrency, performance, error handling, test quality, or business logic — those belong to sibling vertical skills. ## When To Use - Reviewing code structure and readability - Checking Go naming conventions and package organization - Evaluating use of modern Go features - Need to run `golangci-lint` / `staticcheck` / `go vet` ## When NOT To Use - Security vulnerabilities → `go-security-review` - Concurrency safety → `go-concurrency-review` - Error handling correctness → `go-error-review` - Performance optimization → `go-performance-review` - Business logic → `go-logic-review` ## Mandatory Gates ### 1) Go Version Gate Read `go.mod` for `go` directive. Do NOT recommend features above project version. | Feature | Minimum Go | |---------|-----------| | Generics | 1.18 | | Typed atomics (`atomic.Int64`, `atomic.Bool`) | 1.19 | | `slog`, `slices`/`maps` packages, `min`/`max` builtins, `sync.OnceValue`/`OnceFunc` | 1.21 | | Range-over-func, enhanced loop variable semantics | 1.22 | | `iter.Seq`, `unique` package | 1.23 | ### 2) Anti-Example Suppression Gate MUST quote specific code evidence. Category match alone insufficient. Embedded anti-examples: - **"Should use generi...