harness-moaiadk-best-practices

# moai-adk-go Best Practices ## TRUST 5 Quality Gates Every change must pass all five dimensions before completion: | Pillar | Gate | Failure action | |--------|------|----------------| | **Tested** | `go test ./...` with coverage | Block merge; generate missing tests | | **Readable** | `golangci-lint run` | Warn; suggest refactoring | | **Unified** | `go fmt` + `goimports` | Auto-format or warn | | **Secured** | OWASP-aligned review (per-spawn opus agent) | Block; require review | | **Trackable** | Conventional Commits regex | Suggest format | Coverage targets: 85% package minimum; 90%+ for critical packages (`internal/cli`, `internal/template`, `internal/hook`). ## Test Isolation - **Always** `t.TempDir()` for temp dirs — auto-cleanup, under `os.TempDir()`. - **macOS path pitfall**: `t.TempDir()` returns `/var/folders/...`. Go's `filepath.Join(cwd, absPath)` does NOT strip the leading `/`: `filepath.Join("/a/b", "/var/folders/x")` → `"/a/b/var/folders/x"` (WRONG). Use `filepath.Abs()` when resolving user-supplied paths in CLI commands. - **No OTEL env in parallel tests** (CLAUDE.local.md §WARN): never `t.Setenv("OTEL_EXPORTER_*", ...)` in parallel tests — the OTEL SDK initializes global state from env vars on first use, causing data races. Use a fake/no-op exporter instead; or make the parent test non-parallel. - **No `t.Setenv("HOME", tmpDir)`** in GLM integration tests — parallel-test pollution. Use `t.TempDir()` + explicit path construction. - **After...