code-review

Solid

'Review this', 'find bugs', 'is this fix safe': review code for defects that matter, correctness first, each finding refuted before it's reported.

Code & Development 633 stars 85 forks Updated today MIT

Install

View on GitHub

Quality Score: 91/100

Stars 20%
93
Recency 20%
100
Frontmatter 20%
70
Documentation 15%
100
Issue Health 10%
80
License 10%
100
Description 5%
100

Skill Content

# Code Review ## Purpose **Review for supported defects with concrete consequences and checked counterarguments.** Most review output is noise: unranked suspicions that cannot be acted on. Each finding here needs required behaviour, a feasible trigger, a concrete contradiction, an observable consequence and the strongest counterargument checked. **the defects reviewers miss are rarely visible inside one file.** They are disagreements between participants that each look reasonable alone. Examples include caller and callee, producer and consumer, writer and later reader, or branches that should establish the same state. A file-by-file checklist never holds both halves together. Review the agreement, not the file. ## Structure: one engine, three anchors **Use correctness as the core, with performance and security as sub-cases.** Generic tooling covers correctness worst. Each sub-case uses the same engine, refutation discipline and report contract. Only its anchor and one or two extra rules differ. | Sub-case | Anchor | Where its rules live | |---|---|---| | Correctness *(core, default)* | Agreements between participants across a boundary | This file + `references/correctness-taxonomy.md` | | Performance | Workload → resource demand → growth or contention → consequence | `references/performance-review.md` | | Security | Source → trust boundary → sink, with an attacker controlling the source | `references/security-review.md` | **Read a sub-case's file only when that sub-cas...

Details

Author
phuryn
Repository
phuryn/product-engineering
Created
2 weeks ago
Last Updated
today
Language
Python
License
MIT

Similar Skills

Semantically similar based on skill content — not just same category

Code & Development Listed

code-review

Reviewing a change as an engineering activity: setting review depth from the change's risk rather than its size, looking in the order that finds the expensive defects first, refusing to spend human attention on what a formatter or linter should own, writing a finding that can be acted on, separating blocking objections from preferences, and receiving review without either capitulating or defending. Use when reviewing a pull request or a diff, when a review has become a list of style comments, when reviews are slow or rubber-stamped, when a reviewer and an author are deadlocked, when a defect reached production through an approved change, or when deciding what a review must catch versus what CI should. Does not cover the smell catalogue (java-code-smells), SOLID as review criteria (java-solid), readability heuristics (java-clean-code), or which automated gates to run (quality-gates).

3 Updated 3 weeks ago
robsonkades
Code & Development Listed

review-correctness

Review code for bugs, incorrect state transitions, races, and failure handling, including closed-world branching, unknown external values, swallowed errors, masking defaults, invariants, deadlines, cancellation, and retry safety. Use for "review correctness", "review logic", "review defensive", "check exhaustiveness", "fail fast review", or "robustness review".

1 Updated 2 days ago
nielsmadan
Code & Development Listed

code-review

Review a diff for defects that matter, in a fixed order.

2 Updated 1 months ago
corevider