go-observability-review

# Go Observability Review ## Purpose Find observability defects in Go code: logging anti-patterns, trace context breaks, metrics cardinality risks, and span lifecycle errors. This skill covers one dimension only — do not report security, concurrency, or error-handling issues outside observability scope. ## When To Use - Any Go change that imports `go.uber.org/zap`, `log/slog`, `go.opentelemetry.io/`, `github.com/prometheus/client_golang`, `github.com/rs/zerolog` - Diffs adding span creation, metric registration, or logging calls - Files under `observability/`, `telemetry/`, `instrumentation/`, `metrics/`, `tracing/` ## When NOT To Use - Non-Go code - Changes with no logging/tracing/metrics imports or patterns - Security review of authentication logic → go-security-reviewer ## Mandatory Gates ### 1) Execution Integrity Gate Run all 12 grep-gated checklist items BEFORE any semantic analysis. Report the audit line: `Grep pre-scan: X/12 items hit, Z confirmed as findings (2 semantic-only)` ### 2) Anti-Example Suppression Gate BEFORE reporting any finding, check against the false-positive rules in `references/go-review-anti-examples.md`. Apply all matching suppression rules. Suppressed items must appear in the Suppressed Items section with reason. ### 3) Generated Code Exclusion Gate Skip these files entirely — do not grep or analyze: `*.pb.go`, `*_gen.go`, `mock_*.go`, `wire_gen.go`, `*_string.go`, any file starting with `// Code generated` ## Grep-Gated Execution Protoc...