nw-ad-critique-dimensions

Solid

Review dimensions for acceptance test quality - happy path bias, GWT compliance, business language purity, coverage completeness, walking skeleton user-centricity, priority validation, observable behavior assertions, traceability coverage, and walking skeleton boundary proof

Testing & QA 526 stars 55 forks Updated 1 weeks ago MIT

Install

View on GitHub

Quality Score: 92/100

Stars 20%
91
Recency 20%
90
Frontmatter 20%
70
Documentation 15%
100
Issue Health 10%
50
License 10%
100
Description 5%
100

Skill Content

# Acceptance Test Critique Dimensions Load when performing peer review of acceptance tests (during *handoff-develop). ## Dimension 1: Happy Path Bias **Pattern**: Only successful scenarios, error paths missing. Detection: Count success vs error scenarios. Error should be at least 40%. Missing coverage examples: login success but no invalid password | Payment processed but no decline/timeout | Search results but no empty/error cases. Severity: blocker (production error handling untested). ## Dimension 2: GWT Format Compliance **Pattern**: Scenarios violate Given-When-Then structure. Violations: Missing Given context | Multiple When actions (split into separate scenarios) | Then with technical assertions instead of business outcomes. Each scenario: Given (context), When (single action), Then (observable outcome). Severity: high (tests not behavior-driven). ## Dimension 3: Business Language Purity **Pattern**: Technical terms leak into acceptance tests. Flag: database, API, HTTP, REST, JSON, classes, methods, services, controllers, status codes (500, 404), infrastructure (Redis, Kafka, Lambda). Business alternatives: "Customer data is stored" not "Database persists record" | "Order is confirmed" not "API returns 200 OK" | "Payment fails" not "Gateway throws exception" Severity: high (tests coupled to implementation). ## Dimension 4: Coverage Completeness **Pattern**: User stories lack acceptance test coverage. Validation: Map each story to scenarios | Verify all...

Details

Author
nWave-ai
Repository
nWave-ai/nWave
Created
3 months ago
Last Updated
1 weeks ago
Language
Python
License
MIT

Integrates with

Similar Skills

Semantically similar based on skill content — not just same category